Skip to content

Add layer "pull" support via generic code archive download #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2023
Merged

Add layer "pull" support via generic code archive download #11

merged 3 commits into from
Feb 1, 2023

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Jan 31, 2023 •
edited
Loading

Generalizes our "fetch archive content via URL & mount it somewhere" feature.

We can now use LOCALSTACK_CODE_ARCHIVES with a json value of the following format:

[
  {
    "url": "https://example.com/mycodearchive.zip",
    "target_path": "/var/somewhere"
  },
 // ... more fetch & mounting entries
]

For each entry it will fetch the file at the url (expected to be a zip package) and extract it to the target_path.

@dominikschubert dominikschubert self-assigned this Jan 31, 2023
dfangl
dfangl approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at least the parts I didn't write :)

@dominikschubert dominikschubert merged commit db1cead into localstack Feb 1, 2023
@dominikschubert dominikschubert deleted the feat_generic-code-archive-download branch February 1, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

Assignees

@dominikschubert dominikschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschubert @dfangl